rv-b: mark B-ext in misa #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems RISC-V has a Kconfig option indicating B extension. #ifdef CONFIG_RVB
misa->extensions |= ext('b');
#endif |
shinezyy
force-pushed
the
mark-bit-ext-in-misa
branch
from
b5e7f16
to
c36fcad
Compare
poemonsense
approved these changes
Jul 15, 2024
shinezyy
force-pushed
the
mark-bit-ext-in-misa
branch
2 times, most recently
from
2d3b44d
to
54181fa
Compare
cebarobot
reviewed
Jul 22, 2024
| @@ -130,7 +130,7 @@ jobs: | |||
| make riscv64-rvh-diff-spike_defconfig | |||
There was a problem hiding this comment.
I think this config should be changed to riscv64-xs-diff-spike_defconfig. This will solved the current stack overflow problem. But there are still problems because of #407
There was a problem hiding this comment.
Yes, but before 407 is merged, I want to add a guard for NEMU as DUT.
There was a problem hiding this comment.
I think this config should be changed to
riscv64-xs-diff-spike_defconfig. This will solved the current stack overflow problem. But there are still problems because of #407
I enabled RVV in riscv64-rvh-diff-spike_defconfig, and it works.
It does not work with riscv64-xs-diff-spike_defconfig, here is diff:
< # CONFIG_RV_ZICNTR is not set
< # CONFIG_RV_ZIHPM is not set
---
> CONFIG_RV_ZICNTR=y
> # CONFIG_RV_CSR_TIME is not set
> CONFIG_RV_ZIHPM=y
30,31c31,32
< # CONFIG_RV_CSR_MCOUNTINHIBIT_CNTR is not set
< # CONFIG_RV_CSR_MCOUNTINHIBIT_HPM is not set
---
> CONFIG_RV_CSR_MCOUNTINHIBIT_CNTR=y
> CONFIG_RV_CSR_MCOUNTINHIBIT_HPM=y
112c113
< # CONFIG_MEM_COMPRESS is not set
---
> CONFIG_MEM_COMPRESS=y
shinezyy
force-pushed
the
mark-bit-ext-in-misa
branch
4 times, most recently
from
12effbc
to
59b1e79
Compare
- Mark RVB in misa when RVB is enabled. - Unify spike ref so used for RVV and RVH tests. - Add CI running OpenSBI+Linux+Vectorized_h264 with Spike DiffTest, which ensure basic RVH and RVV works. - To prevent mistakenly breaking difftest (as DUT), this patch add an failed testcase into CI to make sure difftest is working as expected. The failed testcase compare NEMU with RVV agnostic enabled against spike (with no agnostic), which should always fail and should print something like `right = .... , wrong = ffffffffffffffff_ffffffff00000003`
shinezyy
force-pushed
the
mark-bit-ext-in-misa
branch
from
59b1e79
to
c8bd307
Compare
shinezyy
commented
Jul 24, 2024
| match=$(grep "wrong.*=.*ffff" crash.log -c) | ||
| if [ ${match} -eq 0 ]; then echo "Difftest is broken, it should report at least one agnostic related difference!" exit 1; fi | ||
| make clean-all | ||
| set +x |
There was a problem hiding this comment.
@poemonsense @cebarobot I check the behavior of a failed case here.
xinhecuican
pushed a commit
to xinhecuican/NEMU
that referenced
this pull request
Aug 31, 2024
…n#397) - Mark RVB in misa when RVB is enabled. - Unify spike ref so used for RVV and RVH tests. - Add CI running OpenSBI+Linux+Vectorized_h264 with Spike DiffTest, which ensure basic RVH and RVV works. - To prevent mistakenly breaking difftest (as DUT), this patch add an failed testcase into CI to make sure difftest is working as expected. The failed testcase compare NEMU with RVV agnostic enabled against spike (with no agnostic), which should always fail and should print something like `right = .... , wrong = ffffffffffffffff_ffffffff00000003`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.